Conversation
TallTed
left a comment
There was a problem hiding this comment.
human-facing language tweaks for clarity
Co-authored-by: Ted Thibodeau Jr <tthibodeau@openlinksw.com>
Co-authored-by: Ted Thibodeau Jr <tthibodeau@openlinksw.com>
Co-authored-by: Ted Thibodeau Jr <tthibodeau@openlinksw.com>
|
@zg009 Thanks for looking at this issue.
The container name
Line 331 in f5652f3 Point 2. may be added in this above function |
…h-test and put in http-test, cleaned up package.json
|
There are tests for invalid slug on POST requests here: https://github.com/nodeSolidServer/node-solid-server/blob/f5652f3dfa3ae630408125af99bcf90b7fe21c0d/test/integration/http-test.js#L863C4-L876C7 I added the check I believe you requested |
|
Sorry I am on a tablet. Not easy to code
The test should create a container. The container name can be found in Your code in |
|
Alain, I do not see how you can do what you are stating is possible. If slug has extension and extension is .acl or .meta, 403 is thrown If slug has no extension, it becomes container. I do not know how the situation you are describing can exist. |
|
@zg009 Could you review at my changes
Can you
|
|
@bourgeoa I renamed it and added some clarity on the new .meta and .acl tests |
bourgeoa
left a comment
There was a problem hiding this comment.
some console in lib/ldp.js to remove
|
Thanks LGTM just remove the 2 console.log() in the recursive |
TallTed
left a comment
There was a problem hiding this comment.
human facing, relatively small
Co-authored-by: Ted Thibodeau Jr <tthibodeau@openlinksw.com>
Co-authored-by: Ted Thibodeau Jr <tthibodeau@openlinksw.com>
wording Co-authored-by: Ted Thibodeau Jr <tthibodeau@openlinksw.com>
wording Co-authored-by: Ted Thibodeau Jr <tthibodeau@openlinksw.com>
wording Co-authored-by: Ted Thibodeau Jr <tthibodeau@openlinksw.com>
Co-authored-by: Ted Thibodeau Jr <tthibodeau@openlinksw.com>
|
@TallTed If it looks good to you, can you go ahead and approve the changes and I'll merge |
|
@TallTed That is OK. It is nice to have more input regarding clarity, when a test or code change has to be revisited later. |
See here: #1692
Added a check in put.js handler to see if a client is attempting to create an invalid resource uri
Alain, before this gets merged, let me know if there is a better way to get the RESERVED_SUFFIXES, and if the function should be moved to ldp.js instead